New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] wraps UI strings with i18n #11

Closed

shawnkchan wants to merge 2 commits into willie-hung:feature/mock-drilldown from shawnkchan:feature/mock-drilldown

Collaborator

shawnkchan commented Nov 30, 2023 •

edited

Loading

Description

Adds i18n wrappers to UI strings

Issues Resolved

Partial fix for issue #2

Screenshot

NA

Testing the changes

NA

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

shawnkchan added 2 commits

November 29, 2023 17:44


          test

ea7734c


          chore: wraps UI strings with i18n wrappers

3f59a4c

github-actions bot added the first-time-contributor label

willie-hung assigned shawnkchan

willie-hung closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time-contributor